[PATCH] D95511: [llvm-readelf] Support dumping the BB address map section with --bb-addr-map.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'd like to do another review pass of the testing before signing off on this, but generally, this is looking good.



================
Comment at: llvm/include/llvm/Object/ELFTypes.h:803
+
+    // The following fields are decoded from the Metadata field according. The
+    // enoding is done in getBBAddrMapMetadata in AsmPrinter.cpp.
----------------
Typo/incomplete sentence?


================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:583
+
+  // Check the proper error handling when the 'NumBlocks" field is overridden
+  // with an out-of-range value.
----------------
I would suggest either "Check for proper error ..." or "Check proper error ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95511/new/

https://reviews.llvm.org/D95511