[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:490
+      Instruction &Inst = *II++;
+      if (match(&Inst, m_Intrinsic<Intrinsic::x86_tdpbssd_internal>()) ||
+          match(&Inst, m_Intrinsic<Intrinsic::x86_tileloadd64_internal>()) ||
----------------
Should be better to use
```
if (auto *Inst  = dyn_cast<IntrinsicInst>&*II++)
  switch (Inst->getIntrinsicID()) {
  case Intrinsic::x86_tdpbssd_internal:
  ...
```


================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:501
+  for (auto *Inst : WorkList) {
+    if (match(Inst, m_Intrinsic<Intrinsic::x86_tdpbssd_internal>()))
+      // %amx1 = bitcast <256 x i32> %vec to x86_amx
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93594/new/

https://reviews.llvm.org/D93594