[PATCH] D96409: [debug-info] refactor emitDwarfUnitLength

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

>>> It seems pretty tidy to me, and I'm pretty sure we follow this pattern elsewhere in the CodeGen/AsmPrinter code.
>>
>> Could you get an example? I can't remember anything similar.
>
> Let's see what I can find...
>
>   mcdwarf::emitListsTableHeaderStart (& related APIs like emitLoclistsTableHeader)
>   AddressPool::emitHeader
>
> Those are a couple I could find at a glance at least.

Is `std::pair<MCSymbol *, MCSymbol *>MCDwarfLineTableHeader::Emit(` also an example for this? It returns `LineEndSym` to its caller and its caller will emits the label.

In D96409#2574195 <https://reviews.llvm.org/D96409#2574195>, @ikudrin wrote:

> In D96409#2572715 <https://reviews.llvm.org/D96409#2572715>, @dblaikie wrote:
>
>> At some point it'd probably be good to include a second (probably as the first parameter) to this function to use as a prefix for the label names to make them more informative/easier to read/modify/etc.
>
> Maybe it'll make sense to do that in this patch. There will be fewer changes in the tests.

Sure, I will update this when the API design is settled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96409/new/

https://reviews.llvm.org/D96409