[PATCH] D96409: [debug-info] refactor emitDwarfUnitLength

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 02:35:48 PST 2021


ikudrin added a comment.

In D96409#2572715 <https://reviews.llvm.org/D96409#2572715>, @dblaikie wrote:

> At some point it'd probably be good to include a second (probably as the first parameter) to this function to use as a prefix for the label names to make them more informative/easier to read/modify/etc.

Maybe it'll make sense to do that in this patch. There will be fewer changes in the tests.

> And the function may need to be renamed - it currently includes the word "unit" un it, even though it can be/is used for other DWARF sections, not just the debug_info/debug_types unit sections.

The method emits a `unit length` field. The name is used throughout the DWARF standard for all kinds of tables. And it hardly can be used for anything else because it may emit a DWARF64 mark.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96409/new/

https://reviews.llvm.org/D96409



More information about the llvm-commits mailing list