[PATCH] D96906: [AMDGPU] gfx90a support

Mark Searles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 14:20:59 PST 2021


msearles added a comment.

In D96906#2572749 <https://reviews.llvm.org/D96906#2572749>, @kzhuravl wrote:

>> The point is that nobody upstream even got a chance to chime in.
>
> We are and will be taking care of any feedback provided in this review post-commit.

To be fair to @rampitec , it was not his desire to push this up in 1 big patch. We needed this upstreamed and no time was given to him to break it up into reasonably sized pieces. If it appears to be his doing/his intent, well, it should not. There have been a couple comments; I believe most addressed; comments will continue to be addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96906/new/

https://reviews.llvm.org/D96906



More information about the llvm-commits mailing list