[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 21 09:56:40 PST 2021


int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:790-792
+  uint8_t *codeEnd =
+      buffer->getBufferEnd() -
+      (codeSignatureSection ? codeSignatureSection->getSize() : 0);
----------------
int3 wrote:
> is this necessary? I don't think hashing a few extra zero bytes makes a difference
this doesn't seem done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96164/new/

https://reviews.llvm.org/D96164



More information about the llvm-commits mailing list