[PATCH] D97131: [AVR] Fix expansion of NEGW

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 21 05:49:23 PST 2021


benshi001 accepted this revision.
benshi001 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:449-450
     MISBCI->getOperand(3).setIsDead();
   // SREG is always implicitly killed
   MISBCI->getOperand(4).setIsKill();
 
----------------
aykevl wrote:
> benshi001 wrote:
> > this line needs to be deleted, otherwise there might be a crash ?
> Why?
Ops, I made a mistake. That is not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97131/new/

https://reviews.llvm.org/D97131



More information about the llvm-commits mailing list