[PATCH] D97126: [WPD] Fix handling of pure virtual base class

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/devirt_pure_virtual_base.ll:6
+; RUN: opt --thinlto-bc -o %t1a.o %s
+; RUN ld.lld %t1a.o -o %t3a -save-temps --lto-whole-program-visibility \
+; RUN   -mllvm -pass-remarks=. 2>&1 | FileCheck %s --check-prefix=REMARK
----------------
MaskRay wrote:
> Seems that this needs to be a ld.lld test and provides a definition for `__cxa_pure_virtual`.
Oops, forgot to remove these. Note they aren't actually running since I removed the : after RUN.


================
Comment at: llvm/test/ThinLTO/X86/devirt_pure_virtual_base.ll:41
+; RUN:   2>&1 | FileCheck %s --check-prefix=REMARK
+; RUN: llvm-dis %t1b.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR
+
----------------
MaskRay wrote:
> `%t1b.o.4.opt.bc` does not exist.
Good catch. I had this file sitting around from an earlier version. Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97126/new/

https://reviews.llvm.org/D97126