[PATCH] D96837: Add !retain metadata to represent SHF_GNU_RETAIN on ELF platforms

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/docs/LangRef.rst:6562-6563
+
+If an explicit section is specified, a unique section will be created to not
+lose linker GC precision.
+
----------------
Would it be possible to expand this sentence a bit? I'm not quite sure what you mean by "loosing linker GC precision".


================
Comment at: llvm/test/CodeGen/X86/elf-retain.ll:1
+; RUN: llc -mtriple=x86_64 < %s | FileCheck %s
+; RUN: llc -mtriple=x86_64 -data-sections=1 < %s | FileCheck %s
----------------
Can you include top-level comment describing the purpose of this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96837/new/

https://reviews.llvm.org/D96837