[PATCH] D97128: [ThinLTO] Make cloneUsedGlobalVariables deterministic
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 20 16:04:45 PST 2021
tejohnson added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:207
// Next build a set of the equivalent values defined in DestM.
for (auto *V : Used) {
auto *GV = DestM.getNamedValue(V->getName());
----------------
Since Used is still a SmallPtrSet, won't we still have non-determinism due to this iteration?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97128/new/
https://reviews.llvm.org/D97128
More information about the llvm-commits
mailing list