[PATCH] D97013: [LTO] Fix cloning of llvm*.used when splitting module

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: llvm/test/Transforms/ThinLTOBitcodeWriter/split-used.ll:25
+; M1: @llvm.compiler.used = appending global [1 x i8*] [i8* @g2]
+ at llvm.used = appending global [2 x i8*] [ i8* @g1, i8* @g3]
+ at llvm.compiler.used = appending global [2 x i8*] [ i8* @g2, i8* @g4]
----------------
MaskRay wrote:
> The canonical form has `, section("llvm.metadata")`.
> 
> With this new patch, `, section("llvm.metadata")` will be appended for M1. I assume that this different does not matter.
The compiler adds this when creating one of these special global values. I didn't bother putting it on the hand created globals here since it didn't matter for the test and keeps it more minimal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97013/new/

https://reviews.llvm.org/D97013