[PATCH] D96978: [WIP] Bias statepoint operands towards spilling

Denis Antrushin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 20 01:43:19 PST 2021


dantrushin added inline comments.


================
Comment at: llvm/lib/CodeGen/CalcSpillWeights.cpp:157
+
+  for (unsigned i = 0, e = MI.getNumOperands(); i < e; ++i) {
+    MachineOperand &MO = MI.getOperand(i);
----------------
skatkov wrote:
> consider using findRegisterUseOperandIdx and findRegisterDefOperandIdx but might be it is an overhead.
isn't this loop is equivalent to
```
for i in [NumDefs, StartIdx) {
  if MO[i].Reg == Reg
    return false;
}
return true;
```
?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96978/new/

https://reviews.llvm.org/D96978



More information about the llvm-commits mailing list