[PATCH] D97108: [Statepoint Lowering] Allow dead gc pointer from deopt section to be on register.

Denis Antrushin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 20 01:13:08 PST 2021


dantrushin added a comment.





================
Comment at: llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:614
 
+  DenseMap<SDValue, int> DeoptLowerAsVReg(LowerAsVReg);
+  auto processDeoptGCPtr = [&](const Value *V) {
----------------
Seems you don't need a map, set would suffice here. Which would greatly simplify code.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:618
+    if (DeoptLowerAsVReg.size() == MaxVRegPtrs)
+      return;
+    // Avoid duplicates.
----------------
You don't need this. Deopt pointers are not relocated, so need not to be limited.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97108/new/

https://reviews.llvm.org/D97108



More information about the llvm-commits mailing list