[PATCH] D97092: [ValueTracking] Handle assumes on arguments with context instruction
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 16:59:46 PST 2021
reames added a comment.
Thinking about it further, there's one property that results from this approach that I really don't like. After this patch, there will be cases where setting a context instruction *pessimizes* the result returned over not including one. That's really not supposed to happen. In particular, it means that for some use cases (analyzing assume calls) forgetting a context instruction now becomes a miscompile. That seems unpleasant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97092/new/
https://reviews.llvm.org/D97092
More information about the llvm-commits
mailing list