[PATCH] D96980: [amdgpu] Revert agnostic SGPR spill.
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 16:28:45 PST 2021
ruiling added a comment.
In D96980#2574913 <https://reviews.llvm.org/D96980#2574913>, @sebastian-ne wrote:
> I think this approach fails when exec is zero.
> The v_mov for the save will be a noop, the v_readfirstline for the restore will read lane 0, which contains some unknown value.
For exec == 0 when reloading, I think the basic block that contains v_readfirstlane will be jumped over, see `SIInsertSkips.cpp` and `hasUnwantedEffectsWhenEXECEmpty()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96980/new/
https://reviews.llvm.org/D96980
More information about the llvm-commits
mailing list