[PATCH] D95859: [asan] Avoid putting globals in a comdat section.

Fri Feb 19 14:10:06 PST 2021

vitalybuka added a comment.

In D95859#2568230 <https://reviews.llvm.org/D95859#2568230>, @pgousseau wrote:

> In D95859#2568106 <https://reviews.llvm.org/D95859#2568106>, @vitalybuka wrote:
>
>> I guess odr-indicator=1 is for reliable ODR violation detection and odr-indicator=0 of smaller binary size.
>
> Thank you for the comment, yes, this change can potentially break the assumption that odr-indicator=0 reduces binary size, as it will prevent certain linker (eg bfd 2.30), to dead strip unused asan globals’ metadata. Do I understand your point correctly?
>
> But I think correct semantic should take priority over binary size optimizations, please let me know your thoughts on this.

Sanitizers don't mind false-negatives if it can noticeably help with some performance metrics. But I can't reproduce expected size regression.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95859/new/

https://reviews.llvm.org/D95859