[PATCH] D97073: [flang][fir] Update flang test tool support classes.

[Valentin Clement via Phabricator via llvm-commits]

clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.

LGTM. There are couple of clang-tidy warnings you might wants to go over before pushing.



================
Comment at: flang/include/flang/Optimizer/Support/FIRContext.h:17
+
+#ifndef FORTRAN_OPTIMIZER_SUPPORT_FIRCONTEXT_H
+#define FORTRAN_OPTIMIZER_SUPPORT_FIRCONTEXT_H
----------------
I thing we get this warning quite often. Is there a difference between header guard in Flang and the one clang-tidy expect? 


================
Comment at: flang/include/flang/Optimizer/Support/FIRContext.h:25
+class ModuleOp;
+}
+
----------------
Do you want to add `// namespace mlir`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97073/new/

https://reviews.llvm.org/D97073