[PATCH] D97036: [X86] Fix a codegen crash in getSetCCResultType

Fri Feb 19 11:13:19 PST 2021

craig.topper added a comment.

In D97036#2574089 <https://reviews.llvm.org/D97036#2574089>, @frasercrmck wrote:

> In D97036#2574085 <https://reviews.llvm.org/D97036#2574085>, @craig.topper wrote:
>
>> Oh I see. changeVectorElementType assumes that if the type is simple and type to change to is simple it will succeed in MVT. That seems like a poor implementation. Maybe it should check the result and fallback to the extended implementation of it fails on MVT?
>
> Yeah that's.. questionable. I'd +1 that change.
>
> This change, though, LGTM.

Grrr. We can't make this change. The extended implementation relies on there being an LLVMTy to get context from. I think there's a bug in EVT::changeVectorElementType if the vector type is simple, but the element type is not. We'll fall into extended implementation, but LLVMTy is null.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97036/new/

https://reviews.llvm.org/D97036