[PATCH] D96979: [DSE] Extending IsGuaranteedLoopInvariant to support a GetElementPtrInst defined in the entry block

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 10:52:13 PST 2021


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

There's similar logic in `MemorySSA.cpp` we should unify.



================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/loop-invariant-entry-block.ll:6
+
+define void @MissedDSEOpportunity(i64 %idx, i1* noalias %cc) {
+; CHECK-LABEL: @MissedDSEOpportunity(
----------------
can you add a comment describing what is tests here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96979/new/

https://reviews.llvm.org/D96979



More information about the llvm-commits mailing list