[PATCH] D96806: [SampleFDO] Stop repeated indirect call promotion for the same target

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

I added PromotedInsns back in https://reviews.llvm.org/rG4ffad1fb489f691825d6c7d78e1626de142f26cf because I found there was some problem in current implementation and it may cause repeated ICP without the protection of PromotedInsns. Basically,  when we read value profile using getValueProfDataFromInst, we specify MaxNumPromotions as the maximum value to read. It is possible that the size of valuedata is larger than MaxNumPromotions so getValueProfDataFromInst ignore some of the 0 count values. I added PromotedInsns back temporarily while I am figuring out what is the best way to fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96806/new/

https://reviews.llvm.org/D96806