[PATCH] D96662: [lit] Add --xfail and --filter-out (inverse of --filter)

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.

I am also happy with `--filter-out`.

In D96662#2574214 <https://reviews.llvm.org/D96662#2574214>, @davezarzycki wrote:

> I agree that `--xfail-file` will be useful but I don't need it yet and I think designing that feature is slightly complicated. Personally, if one is going to have a file, why limit it to just XFAIL? Why not support other `lit` features like `REQUIRES` or `UNSUPPORTED` or `ALLOW_RETRIES`? All of these might be useful to a downstream maintainer that needs to temporarily tweak a test until something is fixed.

Point taken.  Thanks for your patience and for this whole effort! :)

LGTM, with Joel's nits plus one small one from myself.



================
Comment at: llvm/utils/lit/lit/main.py:76
+            selected_tests.append(t)
+
     if not selected_tests:
----------------
Can we do
```
selected_tests = [t for t in discovered_tests if opts.filter.search(t.getFullName()) and not opts.filter_out.search(t.getFullName()]
```

and have a function `mark_xfailing()` just above `mark_excluded()` below?

Thanks!


================
Comment at: llvm/utils/lit/lit/main.py:102
     selected_tests = selected_tests[:opts.max_tests]
 
     mark_excluded(discovered_tests, selected_tests)
----------------
Here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96662/new/

https://reviews.llvm.org/D96662