[PATCH] D97057: [lld-macho] Fix and properly test subtractor relocations

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 08:39:44 PST 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added subscribers: pengfei, kristof.beyls.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

`llvm-mc` doesn't generate any relocations for subtractions
between local symbols -- they must be global -- so the previous test
wasn't actually testing any relocation logic. I've fixed that and
extended the test to cover r_length=3 relocations as well as both x86_64
and arm64.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97057

Files:
  lld/MachO/Arch/ARM64.cpp
  lld/MachO/Arch/X86_64.cpp
  lld/test/MachO/reloc-subtractor.s
  lld/test/MachO/x86-64-reloc-subtract.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97057.324994.patch
Type: text/x-patch
Size: 3778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210219/05a6f95a/attachment-0001.bin>


More information about the llvm-commits mailing list