[PATCH] D95115: [PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 08:19:30 PST 2021


NeHuang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16647
 
+  // If the node, N, is a frame index, ensure that we only only match aligned
+  // DForms if the frame index is aligned. As the `PPC::MOF_NotAddNorCst` flag
----------------
nit: remove duplicate only 


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16657
+    if ((IsDSForm || IsDQForm) && (FlagSet & PPC::MOF_NotAddNorCst)) {
+      // If the address mode computed is a [DS|DQ]Form, double check that that
+      // the frame index is aligned.
----------------
nit: double check if the frame index is aligned 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95115/new/

https://reviews.llvm.org/D95115



More information about the llvm-commits mailing list