[PATCH] D97047: [Analysis][LoopVectorize] do not try to form reductions of pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. While we may want to support pointer min/max in the future (probably not worth it though), we clearly don't now, so bailing out is the right thing to do.

Just one suggestion on placement of the check.



================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:250
       return false;
   } else {
     if (!isIntegerRecurrenceKind(Kind))
----------------
Personally, I'd add an `else if (RecurrenceType->isIntegerTy())` here and then `else return false`. This seems like the place that is making the implicit assumption that the type can only be float or int.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97047/new/

https://reviews.llvm.org/D97047