[PATCH] D96627: [llvm-jitlink] Implement JITLoaderGDB ObjectLinkingLayer plugin for ELF x86-64

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink-gdb-loader.cpp:345
+                  DstKey, SrcKey),
+          inconvertibleErrorCode()));
+    } else {
----------------
sgraenitz wrote:
> I can't reach the ExecutionSession here and there is no Error return value. Any chance we can report that?
> 
> This is due to the "never have more than one pending debug object" restriction above. Otherwise there is no way to determine the right debug object for a MR in the modifyPassConfig() and notifyLoaded() handlers. Or am I missing something?
Error reporting done. The "never have more than one pending debug object" restriction still holds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96627/new/

https://reviews.llvm.org/D96627