[PATCH] D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 05:20:26 PST 2021


arsenm added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:903-904
+  LegalizerHelper Helper(*MF, Info, Observer, B);
+  EXPECT_EQ(Helper.narrowScalar(*UADDO, 0, S32),
+            LegalizerHelper::LegalizeResult::Legalized);
+
----------------
It's a gtest-ism that these should be swapped to get the correct error message as EXPECT_EQ(expected, actual) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96671/new/

https://reviews.llvm.org/D96671



More information about the llvm-commits mailing list