[PATCH] D96662: [lit] Add --xfail and --filter-out (inverse of --filter)

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki updated this revision to Diff 324927.
davezarzycki retitled this revision from "[lit] Add --skip (inverse of --filter) and `--xfail`" to "[lit] Add --xfail and --filter-out (inverse of --filter)".
davezarzycki edited the summary of this revision.
davezarzycki added a comment.

I've renamed `--skip` to `--filter-out`. I prefer "out" to "not" because that matches the documentation for the command.

I'd like to be done with this patch proposal.

If people want to add `--xfail-file` later (or rename `--filter`), go for it. I agree that `--xfail-file` will be useful but I don't need it yet and I think designing that feature is slightly complicated. Personally, if one is going to have a file, why limit it to just XFAIL? Why not support other `lit` features like `REQUIRES` or `UNSUPPORTED` or `ALLOW_RETRIES`? All of these might be useful to a downstream maintainer that needs to temporarily tweak a test until something is fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96662/new/

https://reviews.llvm.org/D96662

Files:
  llvm/docs/CommandGuide/lit.rst
  llvm/utils/lit/lit/cl_arguments.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/Inputs/xfail-cl/false.txt
  llvm/utils/lit/tests/Inputs/xfail-cl/false2.txt
  llvm/utils/lit/tests/Inputs/xfail-cl/lit.cfg
  llvm/utils/lit/tests/Inputs/xfail-cl/true.txt
  llvm/utils/lit/tests/selecting.py
  llvm/utils/lit/tests/xfail-cl.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96662.324927.patch
Type: text/x-patch
Size: 7477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210219/f1fb4f25/attachment.bin>