[PATCH] D95503: [AMDGPU] WQM/WWM: Fix marking of partial definitions

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 02:38:39 PST 2021


critson marked 2 inline comments as done.
critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:311
+          // Compute lanes defined and overlap with use
+          LaneBitmask DefLanes =
+              Op.isUndef() ? LaneBitmask::getAll()
----------------
piotr wrote:
> DefLanes is a bit too similar to DefinedLanes. Can you rename one of them please?
Changed to OpLanes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95503/new/

https://reviews.llvm.org/D95503



More information about the llvm-commits mailing list