[PATCH] D95383: [LV] Remove VPCallback.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4393
+      if (isa<Constant>(ScIncV) ||
+          OrigLoop->contains(cast<Instruction>(ScIncV)))
+        State.Plan->getOrAddVPValue(ScIncV);
----------------
gilr wrote:
> Should this be `!OrigLoop->contains()` to match invariants? (why check at all?)
This is not needed in the latest version, and the code is removed, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9109
 
 void VPTransformState::set(VPValue *Def, Value *IRDef, Value *V,
                            const VPIteration &Instance) {
----------------
gilr wrote:
> Aren't the IRDef parameter(s) now redundant?
Yes, they are not necessary any longer :) 

I removed the VPTransformState::get/set variants with `IRDef`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95383/new/

https://reviews.llvm.org/D95383