[PATCH] D96987: [flang][fir][NFC] Move remaining types to TableGen type definition

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:200
+
+  let printer = [{
+    $_printer << "int<" << getFKind() << '>';
----------------
rriddle wrote:
> I'd prefer that the printers for these are defined with the parser. Can you move these to C++ as well?
Sure


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:345
+    mlir::Type getElementType() const { return getEleTy(); }
+    static ReferenceType get(mlir::Type elementType);
+  }];
----------------
rriddle wrote:
> Use the builders field instead: https://mlir.llvm.org/docs/OpDefinitions/#custom-type-builder-methods
Updated. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96987/new/

https://reviews.llvm.org/D96987