[PATCH] D96963: [lld/mac] reject -undefined warning and -undefined suppress with -twolevel_namespace

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/test/MachO/treat-undef-sym.s:25
+# INVAL_WARNING: error: '-undefined warning' only valid with '-flat_namespace'
+# INVAL_WARNING-NEXT: error: undefined symbol: _bar
+
----------------
int3 wrote:
> nit: can we use hyphens instead of underscores so we don't have mixed separators?
Sure, done.

(I like having them mixed since it makes it clearer that "-NEXT" is some magic lit suffix while "INVAL_WARNING" is just some arbitrary string.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96963/new/

https://reviews.llvm.org/D96963