[PATCH] D97005: Map Parameters marked as dereferenceable during inlining to loads.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 15:50:17 PST 2021


jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

I doubt this is correct. One problem below, one inlined.

  int callee(int *a) { return *a; }
  void caller(int **p) {
    int *a = *p;
    if (a)
      callee(a);
  }



================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1678
+        return false;
+    }
+
----------------
I don't understand how we can ignore non call uses but somehow need a property of call uses, I'm fairly certain a simple bitcast will break this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97005/new/

https://reviews.llvm.org/D97005



More information about the llvm-commits mailing list