[PATCH] D96977: [dfsan] Instrument origin variable and function definitions

Thu Feb 18 15:01:17 PST 2021

gbalats added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:335
+    ShadowWidthBytes = ShadowWidthBits / 8,
+    OriginWidthBits = 32,
+    OriginWidthBytes = OriginWidthBits / 8
----------------
Is this tied to ShadowWidthBits? With fast8, how would this change? 

================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/basic.ll:1-2
+; RUN: opt < %s -dfsan -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK_NO_ORIGIN
+; RUN: opt < %s -dfsan -dfsan-track-origins=1 -dfsan-fast-16-labels=true -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK_ORIGIN
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
----------------
You could use --check-prefixes to merge these.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96977/new/

https://reviews.llvm.org/D96977