[PATCH] D96928: [LICM][Coroutine] Don't sink stores from loops with coro.suspend instructions
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 14:49:12 PST 2021
efriedma added a comment.
I want to see changes to LangRef and/or the coroutine documentation to describe the semantic restriction. If there's a correctness issue, it clearly isn't specific to LICM, so I want to see the rule described in general terms. And please ping llvm-dev when you have it written up.
It's not completely clear to me that disabling sinking is always a performance win, but it's not that important.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96928/new/
https://reviews.llvm.org/D96928
More information about the llvm-commits
mailing list