[PATCH] D96977: [dfsan] Instrument origin variable and function definitions

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:482
 
+  uint64_t numOfElementsInArgOrgTLS();
+
----------------
Can this be constant instead of a function?


================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/basic.ll:11
+; CHECK: @__dfsan_track_origins = weak_odr constant i32 0
+; CHECK_ORIGIN: @__dfsan_track_origins = weak_odr constant i32 1
+; CHECK: @__dfsan_shadow_ptr_mask = external global i64
----------------
IIRC, even with `--check-prefix`, the `CHECK` lines are still verified.  So don't we get a failure for the line above this one (track_origins = 0)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96977/new/

https://reviews.llvm.org/D96977