[PATCH] D96906: [AMDGPU] gfx90a support
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 13:49:11 PST 2021
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199
+ MCRegister RepReg;
+ for (MCRegister R : *MRI->getRegClass(Reg)) {
+ if (!MRI->isReserved(R)) {
+ RepReg = R;
+ break;
+ }
+ }
----------------
arsenm wrote:
> This is a problem because I've removed forAllLanes.
>
> This is a hack, we should be using a different register class for cases that don't support a given subregister index not scanning for an example non-reserved register
This would be massive duplication of all instructions with such operands, isn't it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96906/new/
https://reviews.llvm.org/D96906
More information about the llvm-commits
mailing list