[PATCH] D96409: [debug-info] refactor emitDwarfUnitLength

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Generally looks good to me (please wait for @ikudrin too, to ensure their issues have been addressed)

At some point it'd probably be good to include a second (probably as the first parameter) to this function to use as a prefix for the label names to make them more informative/easier to read/modify/etc. And the function may need to be renamed - it currently includes the word "unit" un it, even though it can be/is used for other DWARF sections, not just the debug_info/debug_types unit sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96409/new/

https://reviews.llvm.org/D96409