[PATCH] D96992: [IR] Move willReturn() to Instruction

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5064
-  if (isa<ResumeInst>(I))
-    return false;
   if (isa<ReturnInst>(I))
----------------
jdoerfert wrote:
> Where did this logic go?
This repeated the logic of `Instruction::mayThrow()` (https://github.com/llvm/llvm-project/blob/b7e05c874b5b2a77c87df71ee3442abc2569cbb9/llvm/lib/IR/Instruction.cpp#L621-L629), so I folded it into the call below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96992/new/

https://reviews.llvm.org/D96992