[PATCH] D96351: [AIX] Enable the default AltiVec ABI on AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 13:38:22 PST 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:59
+
+; MIR32-EXT-LABEL:   INLINEASM
+
----------------
hubert.reinterpretcast wrote:
> Is this considered to "modify" the reserved registers that are marked as clobbers? I don't think D93659 should generate a traceback table that indicates that the reserved registers are saved in the save area if they are not.
Looping back here:

  - We are okay to omit both the save and the restore here when a user insists on using the reserved registers (even though they are not supposed to). Note: XL oddly generates the save but not the restore.
  - We will try to generate a warning when the user specifies the reserved registers for inline assembly/explicit register variables.


Separately from this patch:

  - We need to fix the vector save/restore to save all of the registers in the range for the unwinder to restore.
  - We need to update the traceback table emission to signal cases where the field indicating the number of saved vector registers is reliable.
  - D93659 should be updated to not indicate any saved non-volatile vector registers when the default AIX vector ABI is used.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351



More information about the llvm-commits mailing list