[PATCH] D96906: [AMDGPU] gfx90a support

Wed Feb 17 16:52:29 PST 2021

tra added a comment.

In D96906#2570095 <https://reviews.llvm.org/D96906#2570095>, @rampitec wrote:

> It's a year of work necessarily downstream. Every line there was reviewed and tested in the downstream. I understand no one can reasonably review something that big, although I cannot break it into small patches after a year of changes and fixes. Not that I have too much choice.

The point is that nobody upstream even got a chance to chime in.

According to https://llvm.org/docs/CodeReview.html

> We expect significant patches to be reviewed before being committed.

This patch certainly qualifies as significant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96906/new/

https://reviews.llvm.org/D96906