[PATCH] D95638: AMDGPU: Add target id and code object v4 support

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl marked an inline comment as done.
kzhuravl added a comment.

In D95638#2564830 <https://reviews.llvm.org/D95638#2564830>, @jhenderson wrote:

> In D95638#2531247 <https://reviews.llvm.org/D95638#2531247>, @kzhuravl wrote:
>
>> In D95638#2530115 <https://reviews.llvm.org/D95638#2530115>, @jhenderson wrote:
>>
>>> I've only looked at the llvm-readobj stuff: there are a very large number of changes to that tool in this change, but no direct testing (i.e. tests under llvm\test\llvm-readobj) that has been changed. I'm guessing it's not all covered by existing direct testing of the tool?
>>
>> It is not covered by the direct testing of the tool (no tests in llvm\test\llvm-readobj), but has a very good coverage in llvm/test/CodeGen/AMDGPU.
>
> Usually we have testing for llvm-readobj behaviour in test/tools/llvm-readobj, so that it can be kept independent of other testing, and so that changes in other areas don't impact test coverage for llvm-readobj. It also makes it easier to keep the tests focused on individual features. For example, what testing is there for EM_AMDGPU objects with an unrecognised ABI Version, or other aspects of that switch?

Updated llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-hea ders.test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95638/new/

https://reviews.llvm.org/D95638