[PATCH] D95924: [Example][NFC} Add testcase for BrainF HelloWorld

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/Examples/BrainF/HelloWorld.ll:1
+; RUN: BrainF %s -o - | llvm-dis | FileCheck %s
+++++++++[>++++[>++>+++>+++>+<<<<-]>+>+>->>+[<]<-]>>.>---.+++++++..+++.>>.<-.<.+++.------.--------.>>+.>++.
----------------
Probably `; REQUIRES: default_triple`?


================
Comment at: llvm/test/Examples/BrainF/HelloWorld.ll:4
+
+# CHECK:      define void @brainf() {
+# CHECK-NEXT:      brainf:
----------------
These should generally be CHECK-LABEL


================
Comment at: llvm/test/Examples/BrainF/HelloWorld.ll:13
+# CHECK:             br label %brainf3
+
+# CHECK:           brainf1:                                          ; preds = %brainf55
----------------
Don't put blank lines in the middle of functions


================
Comment at: llvm/test/Examples/BrainF/HelloWorld.ll:19
+
+# CHECK:      declare noalias i8* @malloc(i32)
+
----------------
I doubt you care about these


================
Comment at: llvm/test/Examples/BrainF/HelloWorld.ll:27
+# CHECK-NEXT:        ret i32 0
+# CHECK       }
----------------
Missing `:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95924/new/

https://reviews.llvm.org/D95924