[PATCH] D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 11:49:02 PST 2021


amyk added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/p10-constants.ll:249
+
+; Leading Zeros + Trailing Ones > 30
+define  i64 @t_LZTO() {
----------------
amyk wrote:
> I noticed we don't really use the term `Trailing Ones`, but we use `Following Ones`. Would it be better if we said `Following Ones` here?
Actually, you can disregard this comment. I made a mistake. We have both `Trailing Ones` and `Following Ones` in this patch. Sorry about that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93300/new/

https://reviews.llvm.org/D93300



More information about the llvm-commits mailing list