[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS
Paul via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 11:15:04 PST 2021
cynecx added inline comments.
================
Comment at: lld/MachO/SyntheticSections.h:491
+ const ssize_t blockSize = (1 << blockSizeShift); // 4 KiB
+ const size_t hashSize = 256 / 8;
+ const uint32_t blobHeadersSize =
----------------
cynecx wrote:
> Since we are currently hard-wiring sha256, we should just use the appropriate constant here.
Oh crap. The constant is actually private. Nvm then. Perhaps add a comment then?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96164/new/
https://reviews.llvm.org/D96164
More information about the llvm-commits
mailing list