[PATCH] D95232: Symbolizer - Teach symbolizer to work directly on object file.
praveen velliengiri via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 08:58:50 PST 2021
pvellien added a comment.
In D95232#2567721 <https://reviews.llvm.org/D95232#2567721>, @jhenderson wrote:
> I'm not sure if this is what @dblaikie was referring to, but it seems like a good way to test new public-facing APIs would be to write gtest unit tests. I don't think there's any precedent for this for the symbolizer API, so it may not be particularly easy. Refactoring llvm-symbolizer to make use of the new API is probably a good idea, and it may help with the test coverage, but there is a risk that a future refactor beyond that will cause llvm-symbolizer to no longer use the API, and therefore the test coverage is lost.
@jhenderson so if we about to write unit tests for new symbolizer APIs how one should proceed? I would like to get your thoughts since there is no unit tests for Symbolizer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95232/new/
https://reviews.llvm.org/D95232
More information about the llvm-commits
mailing list