[PATCH] D96928: [LICM][Coroutine] Don't sink stores from loops with coro.suspend instructions
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 08:55:50 PST 2021
lxfind added a comment.
In D96928#2570981 <https://reviews.llvm.org/D96928#2570981>, @junparser wrote:
> please see comments of D87817 <https://reviews.llvm.org/D87817>.
I don't think we should go that route, because LICM will mostly hurt coroutine, as I explained in the summary.
Hence we should simply disable LICM for coroutine, and I don't think this is a temporary change. What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96928/new/
https://reviews.llvm.org/D96928
More information about the llvm-commits
mailing list