[PATCH] D95561: [Clang] Introduce Swift async calling convention.

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 08:25:05 PST 2021


rjmccall added a comment.

LGTM other than the TargetInfo thing.



================
Comment at: clang/include/clang/Basic/TargetInfo.h:1424
+           triple.isAArch64();
+  }
+
----------------
As I commented in the other patch, I think this would be cleaner in the long term if you just implemented it directly in the various target subclasses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95561/new/

https://reviews.llvm.org/D95561



More information about the llvm-commits mailing list