[PATCH] D96953: [SVE] fix IRMover returning wrong modified vector type

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 08:02:19 PST 2021


sdesmalen added inline comments.


================
Comment at: llvm/test/Linker/Inputs/fixed-vector-type-construction.ll:3
+define void @foo(<4 x %t*> %x) {
+    ret void
+}
----------------
nit: please use 2 spaces.


================
Comment at: llvm/test/Linker/scalable-vector-type-construction.ll:1
+; RUN: llvm-link %p/Inputs/fixed-vector-type-construction.ll %p/scalable-vector-type-construction.ll -S -o - | FileCheck %s
+%t = type {i32, float}
----------------
use `%s` directly (that expands to the same)


================
Comment at: llvm/test/Linker/scalable-vector-type-construction.ll:6
+define void @bar(<vscale x 4 x %t*> %x) {
+    ret void
+}
----------------
nit: please use 2 spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96953/new/

https://reviews.llvm.org/D96953



More information about the llvm-commits mailing list