[PATCH] D96941: [dfsan] Refactor defining TLS variables
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 18 07:55:47 PST 2021
morehouse added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1073
+ return C;
+}
+
----------------
Considering this function is only useful inside `runImpl`, it might be better to use a lambda there instead. Then we can also capture `Mod` and `Changed` instead of passing them every time.
Then we could also probably avoid passing the `Ty`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96941/new/
https://reviews.llvm.org/D96941
More information about the llvm-commits
mailing list