[PATCH] D96958: sysroot.py: add support for darwin

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 07:44:12 PST 2021


hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/sysroot.py:39
     elif sys.platform == 'darwin':
-        assert False, "FIXME: Implement on darwin"
+        # The SDKs used by default in compiler-rt/cmake/baes-config-ix.cmake.
+        # COMPILER_RT_ENABLE_IOS defaults to on.
----------------
s/baes/base/


================
Comment at: llvm/utils/sysroot.py:42
+        # COMPILER_RT_ENABLE_WATCHOS and COMPILER_RT_ENABLE_TV default to off.
+        # comipler-rt/cmake/config-ix.cmake sets DARWIN_EMBEDDED_PLATFORMS
+        # depending on these.
----------------
s/comipler/compiler/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96958/new/

https://reviews.llvm.org/D96958



More information about the llvm-commits mailing list